Repository navigation
fix(status): WATCH an Agent Editor project whose .mxmodule does not travel with the model (#778) - #786
Conversation
…ravel with the model (#778) Studio Pro reads the agenteditor.agent type from modules/AgentEditor.mxmodule beside the .mpr; a sync of only .mpr + mprcontents/ dropped it from git, so every colleague's clone broke while the builder stayed green. bin/status.sh now WATCHes (warn-only, exit code and verdicts unchanged, local git ls-files and file existence only, root and app/ layouts) a modules/*.mxmodule git does not track, and a project using Agent Editor (inventory.json or a `create agent` statement) with no AgentEditor*.mxmodule. skills/mendix-agents.md gains the learned rule and the GenAI key / constants note. Agent reference and runtime-constant checks are left for option 2 (need a capture). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX. The Value: Option 1 of #778, as decided. It adds two WATCH items ( Regression risk: No verdict or exit code changes.
Correctness:
Context cost: 66,271 → 66,271 (measured). Time cost: per Exact fixes required:
Generated by Claude Code |
…at line start; T9 comment/string case Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE (re-review). The detector is now anchored to a statement at line start, and Probes:
The new T9 case fails against the pre-fix Fixtures:
Always-loaded words are unchanged at 66,271. Generated by Claude Code |
…itor-warn # Conflicts: # CHANGELOG.md
…itor-warn # Conflicts: # CHANGELOG.md
Fixes #778
Direct lane
What changed and why (one paragraph): This is option 1 of the triage (warn only, maintainer's go on 2026-11-16). Studio Pro reads the
agenteditor.agentdocument type frommodules/AgentEditor.mxmodulebeside the.mpr. A sync of only.mpr+mprcontents/left that file out of git, so the builder stayed green while every colleague's clone showedunknown type 'agenteditor.agent'.bin/status.shnow adds two WATCH items next to the existing #523 / #765 ones:extension module not in git: <path>, for anymodules/*.mxmodulethat git does not track.project uses Agent Editor but <path> is missing, when nomodules/AgentEditor*.mxmodulesits beside the.mprand either of these is true:analysis/app-facts/inventory.jsonlistsAgentEditorCommons;mdlsource/*.mdlfile holds acreate agentstatement.Both layouts are handled: root, and
app/, whetherapp/is its own repo or part of the root repo. The check reads only local files andgit ls-files, with no mxcli calls. The exit code (always 0) and every verdict are unchanged.skills/mendix-agents.md(on demand) gets a new section, "A colleague's clone must run it too". It adds the learned rule "commitmodules/*.mxmodulewith the model; a sync of only.mpr+mprcontents/drops extension types". It also adds the GenAI key /Encryption.EncryptionKey/GenAICommons.StoreTracesnote. Each comes with a one-line failure example and a checklist row.Left out (needs option 2): the empty agent references / missing
selectedModelcheck (mendixlabs/mxcli#1867) and the unset runtime constants check. Both need a captured mxcli output of a real agent document, and building them on hand-written input would break field-proof rule 1.Impact
bin/status.sh(screen and--brief), shown only on projects that have a.mxmoduleor use Agent Editor. No new artifacts.bin/status.shonly: a new block, plus one more variable in the WATCH loop. Another open PR that edits the same WATCHforline would need a one-token merge. No new tools. New optional read:analysis/app-facts/inventory.json, produced bybin/app-facts.sh; themdlsource/grep covers projects that never ran it.render-routing.sh --check).mendix-agents.mdis on demand (2,038 → 2,219 words)..mxmodule).Time cost: per status run · 0.010 s measured on a Linux x86_64 container · can force rework: n · offset: maintainer OK
Field evidence: observed in a field project with Agent Editor agents (Nov 2026, reported in #778). It is UNVERIFIED against that project, since no Agent Editor project is available here. The fixture rebuilds the situation from real git repos in temp dirs.
Fixture:
tests/wave2/test-status-extension-modules.sh(realbin/init-project.shscaffold, real git repos, both layouts).bin/status.shOn master, T1, T3, T5, T6 and T8 fail; only the negative cases pass.
Existing
status.shfixtures on the branch:test-status-existing-apptest-status-teamservertest-status-lint-unversionedtest-status-session-cwdtest-status-bare-varcheck-scripts.sh, the leak guard,check-pr-discipline.shandcheck-portability.share clean.grep -rqiE --includeandgit ls-filesonly.CHANGELOG.mdline appended, creditedReview: pending independent review
Generated by Claude Code